[Placeholder] Allow executing Placeholders in the execution engine. #1597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavrot
commented
Sep 8, 2018
| class Tensor; | ||
|
|
||
| /// Maps placeholders to the tensors that back them. | ||
| using PlaceholderMap = std::unordered_map<Placeholder *, Tensor *>; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This was referenced Sep 9, 2018
|
The second part of this PR is #1601, which adds CPU and OpenCL support for the changes to the execution engine. |
hegemanjwh2
approved these changes
Sep 9, 2018
| assert(placeholders.size() == inputs.size() && | ||
| "Invalid number of placeholders"); | ||
|
|
||
| for (int i = 0, e = placeholders.size(); i < e; i++) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Implement the logic for executing Placeholders in the execution engine. This commit changes the backend interface and adds the ability to pass Placeholder variables in addition to Variables. This change breaks the out-of-tree backends. This is the first step in adding support for placeholder variables in the execution engine. The commit adds support to the interpreter but not to the OpenCL and CPU backends.
nadavrot
force-pushed
the
compile_placeholders
branch
from
db2cdbf to
32eb209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implement the logic for executing Placeholders in the execution engine.
This commit changes the backend interface and adds the ability to pass
Placeholder variables in addition to Variables. This change breaks the
out-of-tree backends.
This is the first step in adding support for placeholder variables in
the execution engine. The commit adds support to the interpreter but not
to the OpenCL and CPU backends.
Testing: Ran the local tests (ninja check)
Documentation: updated doxygen comments.
Related to #1586 and #1334.